Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add screencast functionality #494

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add screencast functionality #494

wants to merge 7 commits into from
+238 −0

Conversation

bradleyscollins
Copy link

This pull request adds an API that exposes CDP's screencast capability.

See the following:

Note: At this time, the Chrome DevTools Protocol documentation still has screencast methods/types marked as "experimental."

@bradleyscollins
Copy link
Author

A number of the test failures are on account of a difference between expected vs. actual screenshot height.

We noticed that as of Chrome 128, the heights of our screenshot/screencast images were different from (less than) the height specified in the window_size option of the Browser constructor. We had to set the viewport size explicitly to get the expected screenshot height.

@route
Copy link
Member

route commented Nov 20, 2024

@bradleyscollins could you please rebase on master? after that we can merge, should be fixed in there

@bradleyscollins
Copy link
Author

@route, I think I have rebased correctly (and fixed a brittle test). Just let me know if there's anything else you need me to do.

And thank you for your kind consideration of my pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bradleyscollins @route